Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update releases page #3782

Merged
merged 2 commits into from
Oct 31, 2023
Merged

docs: update releases page #3782

merged 2 commits into from
Oct 31, 2023

Conversation

janhassel
Copy link
Member

I found the current releases page to be a bit confusing for the following reasons:

  • The preferred @carbon/react package isn't listed
  • The carbon-components-react package is called Carbon React which sounds like it's referring to @carbon/react
  • Some of the links were pointing to the wrong versions

Changelog

Changed

  • On "All about Carbon -> Releases -> Release History"
    • Renamed column headers to use actual package names
    • Added column @carbon/react
    • Updated version links if possible1

Footnotes

  1. Is it intentional, that carbon-components@latest directs to 10.x and carbon-components-react@latest points to 8.x? I'd imagine these versions are incompatible and could mess with one's initial setup.
    Maybe this could be updated and the following tags could be created in which case they could be linked in this page: @carbon/[email protected], [email protected], [email protected] ↩

@janhassel janhassel requested review from a team as code owners October 18, 2023 07:53
@vercel
Copy link

vercel bot commented Oct 18, 2023

@janhassel is attempting to deploy a commit to the Carbon Design System Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 5:18pm

alisonjoseph
alisonjoseph approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 623392f into carbon-design-system:main Oct 31, 2023
6 checks passed
@janhassel janhassel deleted the release-history-update branch November 2, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan tw15egan was automatically assigned from carbon-design-system/developers-system

@andreancardona andreancardona Awaiting requested review from andreancardona andreancardona was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: one more review 👀 status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janhassel @alisonjoseph @laurenmrice