Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in step-1.mdx #3778

Closed
wants to merge 2 commits into from
Closed

Conversation

cassiasamp
Copy link

@cassiasamp cassiasamp commented Oct 16, 2023

Closes #

Just adding some detail to instructions about creating an empty app.scss file.
The parts in the tutorial about recompiling starting on line 182 are still unclear to me as their meaning.
So, I hope the creation of this empty file is the right way to go and it seems a good idea to make it explicit.

Changelog

New

  • Included "(...) a separate file. Create an empty file app.scss in the 'src' directory, and then import it in (...)"

Changed

  • The line "speed this up by moving our custom app Sass into a separate file, app.scss in
    the 'src' directory, and import that from App.js."

Removed

  • Some words and punctuation.

Adding detail to instructions about creating an empty app.scss file. The parts about recompiling starting on line 182 are still unclear as their meaning. So, I hope the creating of this empty file is the right way to go.
@cassiasamp cassiasamp requested review from a team as code owners October 16, 2023 14:53
@vercel
Copy link

vercel bot commented Oct 16, 2023

@cassiasamp is attempting to deploy a commit to the Carbon Design System Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

DCO Assistant Lite bot All contributors have signed the DCO.

@cassiasamp
Copy link
Author

I have read the DCO document and I hereby sign the DCO.

@cassiasamp
Copy link
Author

recheck

@guidari
Copy link
Contributor

guidari commented Oct 19, 2023

Hey @cassiasamp thank you for your contribution!

We are actually doing a new tutorial using NextJS in this PR which means the current tutorial will be sunset soon.

@cassiasamp
Copy link
Author

Thanks @guidari, that's an interesting info...would you say it's best if I switch from React to Next.js?
I'm guessing the new tutorial would make things simpler 😅

@alisonjoseph
Copy link
Member

Closing this as the tutorial will be updated in #3710 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants