Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: and Carbon champion names #3756

Merged

Conversation

aubrey-oneal
Copy link
Member

@aubrey-oneal aubrey-oneal commented Sep 27, 2023

Closes #3753

Changelog

New

  • Add Carbon champion names (only those who have filled out the consent form)

Removed

  • Nomination form (we can't have this because it collects PI)
  • Contribution Gallery section with Airtable iframe

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 3:11pm

@aubrey-oneal aubrey-oneal changed the title add: Carbon champion names docs: and Carbon champion names Sep 27, 2023
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small things otherwise looks good!

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me pending the typos Andrea mentioned and Jeannie's review of the Carbon Champions layout.

Copy link
Collaborator

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new champions look!

@jeanservaas
Copy link
Collaborator

@aubrey-oneal one thing...

For Shankar, since you don't have a verb anywhere else, maybe I'd remove the "Create" for Shankar

image

@aubrey-oneal aubrey-oneal merged commit 6c4be8c into carbon-design-system:main Oct 2, 2023
6 checks passed
@aubrey-oneal aubrey-oneal deleted the carbon-champions-3753 branch October 2, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website docs: Champions section
4 participants