-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(codeowners): removed #3752
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed your comment on the original issue. The CODEOWNERS
file ensures that the listed "code owners" are automatically requested for review when someone opens a pull request that modifies code that they own.
In this case it powers the automatic review requests from the team for all PRs and then also requests reviews from other folks if the files modified match the paths specified in the file.
A lot of them are out of date with folks no longer involved with Carbon, but some of them are still valid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some formatting issues
Co-authored-by: TJ Egan <[email protected]>
Co-authored-by: TJ Egan <[email protected]>
Co-authored-by: TJ Egan <[email protected]>
Co-authored-by: TJ Egan <[email protected]>
@tw15egan i committed the changes, but it looks like the errors are from the fact that the code owners in question don't have write access to the monorepo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sstrubberg I added all 4 'erroring' users to the carbon-design-system/maintainers-website-patterns
team, should be good to go. Everyone was already in the org except @natashadecoste so we'll have to wait on them to accept the invite. I think it's okay to merge this even with that outstanding error.
Closes #2897