Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codeowners): removed #3752

Merged
merged 10 commits into from
Sep 28, 2023
Merged

Conversation

sstrubberg
Copy link
Member

Closes #2897

@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 11:42pm

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed your comment on the original issue. The CODEOWNERS file ensures that the listed "code owners" are automatically requested for review when someone opens a pull request that modifies code that they own.

In this case it powers the automatic review requests from the team for all PRs and then also requests reviews from other folks if the files modified match the paths specified in the file.

A lot of them are out of date with folks no longer involved with Carbon, but some of them are still valid.

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Show resolved Hide resolved
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some formatting issues

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@sstrubberg
Copy link
Member Author

@tw15egan i committed the changes, but it looks like the errors are from the fact that the code owners in question don't have write access to the monorepo

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sstrubberg I added all 4 'erroring' users to the carbon-design-system/maintainers-website-patterns team, should be good to go. Everyone was already in the org except @natashadecoste so we'll have to wait on them to accept the invite. I think it's okay to merge this even with that outstanding error.

@tw15egan tw15egan merged commit 26a23b8 into carbon-design-system:main Sep 28, 2023
6 checks passed
@sstrubberg sstrubberg deleted the codeowners branch September 28, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CODEOWNERS] List of codeowners is out of date
7 participants