Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menubutton: dev/style updates #3791

Closed
2 of 8 tasks
Tracked by #3563
sstrubberg opened this issue Oct 31, 2023 · 0 comments · Fixed by carbon-design-system/carbon#15398
Closed
2 of 8 tasks
Tracked by #3563

Menubutton: dev/style updates #3791

sstrubberg opened this issue Oct 31, 2023 · 0 comments · Fixed by carbon-design-system/carbon#15398

Comments

@sstrubberg
Copy link
Member

sstrubberg commented Oct 31, 2023

  • Direction There could be use cases where people want to place the menu button at the bottom. Could this add a prop to have the alignment upward? Similar to popover alignment
  • Alignment How do people align the button to the right of the menu in the code?

Design Specs

carbon-design-system/carbon#14918

Acceptance Criteria

  • New prop(s) for the alignment
  • New prop(s) for the direction
  • The actual changes to styles coming from these props (and also the new max-heights)
  • new stories and controls on the stories (directionality, etc. like popover)
  • VRT
  • maybe unit tests
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Oct 31, 2023
@sstrubberg sstrubberg moved this from Triage to Now in Roadmap Oct 31, 2023
@sstrubberg sstrubberg moved this to ⏱ Backlog in Design System Oct 31, 2023
@sstrubberg sstrubberg added this to the 2023 Q4 milestone Oct 31, 2023
@sstrubberg sstrubberg changed the title Menubutton: storybook Menubutton: storybook updates Oct 31, 2023
@alisonjoseph alisonjoseph changed the title Menubutton: storybook updates Menubutton: dev/style updates Nov 29, 2023
@tay1orjones tay1orjones modified the milestones: 2023 Q4, 2024 Q1 Dec 13, 2023
@github-project-automation github-project-automation bot moved this from Now to Completed in Roadmap Feb 5, 2024
@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants