Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComboButton: dev/style updates #3790

Closed
2 of 8 tasks
Tracked by #3563
sstrubberg opened this issue Oct 31, 2023 · 1 comment · Fixed by carbon-design-system/carbon#15398
Closed
2 of 8 tasks
Tracked by #3563

ComboButton: dev/style updates #3790

sstrubberg opened this issue Oct 31, 2023 · 1 comment · Fixed by carbon-design-system/carbon#15398
Assignees
@andreancardona @guidari
Labels
component: combo-button role: dev 🤖 type: enhancement 💡

Comments

@sstrubberg
Copy link
Member

sstrubberg commented Oct 31, 2023 •
edited
Loading

  • Direction There could be use cases where people want to place the menu button at the bottom. Could this add a prop to have the alignment upward? Similar to popover alignment
  • Alignment How do people align the button to the right of the menu in the code?

Design Specs

carbon-design-system/carbon#14918

Acceptance Criteria

  • New prop(s) for the alignment
  • New prop(s) for the direction
  • The actual changes to styles coming from these props (and also the new max-heights)
  • new stories and controls on the stories (directionality, etc. like popover)
  • VRT
  • maybe unit tests
@sstrubberg sstrubberg mentioned this issue Oct 31, 2023
Closed
@sstrubberg sstrubberg moved this to ⏱ Backlog in Design System Oct 31, 2023
@sstrubberg sstrubberg added this to the 2023 Q4 milestone Oct 31, 2023
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Oct 31, 2023
@sstrubberg sstrubberg moved this from Triage to Now in Roadmap Oct 31, 2023
@sstrubberg sstrubberg changed the title Combobutton: storybook Combobutton: storybook updates Oct 31, 2023
@sstrubberg sstrubberg changed the title Combobutton: storybook updates ComboButton: storybook updates Oct 31, 2023
@sstrubberg sstrubberg mentioned this issue Oct 31, 2023
Closed
8 tasks
@alisonjoseph alisonjoseph changed the title ComboButton: storybook updates ComboButton: dev/style updates Nov 29, 2023
@guidari guidari moved this from ⏱ Backlog to 🏗 In Progress in Design System Dec 7, 2023
@thyhmdo
Copy link
Member

thyhmdo commented Dec 13, 2023

Specs:

Combo button specs

@guidari guidari mentioned this issue Jan 3, 2024
Merged
1 task
@tay1orjones tay1orjones moved this from 🏗 In Progress to 🚦 In Review in Design System Jan 3, 2024
@github-project-automation github-project-automation bot moved this from Now to Completed in Roadmap Feb 5, 2024
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreancardona andreancardona

@guidari guidari

Labels
component: combo-button role: dev 🤖 type: enhancement 💡
Projects
Design System
Archived in project
Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Menu and Friends workstream guidari/carbon
4 participants
@sstrubberg @andreancardona @guidari @thyhmdo