Skip to content

Commit

Permalink
menu update
Browse files Browse the repository at this point in the history
  • Loading branch information
thyhmdo committed Oct 18, 2023
1 parent dc7d06b commit 40c91ac
Show file tree
Hide file tree
Showing 9 changed files with 17 additions and 19 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 10 additions & 13 deletions src/pages/components/menu-buttons/usage.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -563,31 +563,28 @@ experience.
</Column>
</Row>

#### Overflow versus tab tip(popover)
#### Overflow versus tab tip (popover)

Overflow menu employs the menu component to display extra options, typically
utilized within data table rows, tiles, or cards. In contrast,
[tab tip popovers](https://carbondesignsystem.com/components/popover/usage/#tab-tip)
appear as nested elements on a page, tethered to a toolbar or header area.
Overflow menu displays extra options with simple text, typically utilized within
data table rows, tiles, or cards.
[Tab tip](https://carbondesignsystem.com/components/popover/usage/#tab-tip) in
popover provides more complex inputs such as a checkbox group or a radio button
group, usually connected to a data table toolbar.

<Row>
<Column colLg={4}>

![An example of another overflow menu icon](images/usage-overflow-menu.png)

<Caption>Use overflows in data table row</Caption>
![An example of overflow menu](images/usage-overflow-menu.png)

<Caption>Use overflow menus in data table row</Caption>
</Column>

<Column colLg={4}>

![An example of another overflow menu icon](images/usage-popover.png)
![An example of a popover](images/usage-popover.png)

<Caption>Use a popover in the data table toolbar</Caption>
</Column>

<Caption>
Use tab tip popovers in toolbar or header area
</Caption>
</Row>

## Related
Expand Down
2 changes: 1 addition & 1 deletion src/pages/components/menu/code.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ documentation, see the Storybooks for each framework below.
variants={[
{
label: 'Menu',
variant: 'components-menu--default',
variant: 'components-context-menu--default',
},
]}
/>
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 5 additions & 4 deletions src/pages/components/menu/style.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,10 @@ hover, danger hover and focus, and disabled.

## Sizes

The height of a menu is determined by a [menu button](menu-buttons/). Menus have
a fixed minimum width of 160px (or 10rem), to ensure menu items have sufficient
horizontal space, while also having a fixed maximum width of 288px (or 18rem).
The height of a menu is determined by a
[menu button](/components/menu-buttons/style/). Menus have a fixed minimum width
of 160px (or 10rem), to ensure menu items have sufficient horizontal space,
while also having a fixed maximum width of 288px (or 18rem).

| Elements | Size | Height (px/rem) |
| ----------- | ------------------ | --------------- |
Expand All @@ -133,6 +134,6 @@ horizontal space, while also having a fixed maximum width of 288px (or 18rem).

<div className="image--fixed">

![Modal sizes](images/style-menu-sizes.png)
![Menu sizes](images/style-menu-sizes.png)

</div>
2 changes: 1 addition & 1 deletion src/pages/components/menu/usage.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ of a menu.
variants={[
{
label: 'Menu',
variant: 'components-menu--default',
variant: 'components-context-menu--default',
},
]}
/>
Expand Down

0 comments on commit 40c91ac

Please sign in to comment.