Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): introduce cypress for web components & react storybook #7096

Merged
merged 14 commits into from
Sep 10, 2021
Merged

test(e2e): introduce cypress for web components & react storybook #7096

merged 14 commits into from
Sep 10, 2021

Conversation

jeffchew
Copy link
Member

@jeffchew jeffchew commented Sep 9, 2021 •
edited
Loading

Related Ticket(s)

Refs #6139

Description

This PR fully moves the existing test-e2e package to a dedicated cypress test setup for web components and react storybooks. A few tests have been included for masthead, locale-modal, and leadspace. They are largely focused on snapshot testing, though percy has been disabled for now as rendering of dynamic states are still not supported in percy for web components (see percy/cli#280).

Actual cypress tests can be created now though, and also the current tests uses the built-in cypress screenshot feature:

image

And video that shows how the tests are run:

masthead.e2e.js.mp4

Changelog

New

  • Cypress testing for web components and react storybook

Changed

  • disabled video recording by default to speed up tests

Removed

  • Removed test-e2e package

@jeffchew jeffchew requested a review from a team as a code owner September 9, 2021 13:45
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 9, 2021 •
edited
Loading

Deploy preview created for package Web Components - Codesandbox Examples:
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7096/

Built with commit: 1d8c28e4e4660639b4d6e6256ab9ddc2d4943820

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 9, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7096/index.html

Built with commit: 1d8c28e4e4660639b4d6e6256ab9ddc2d4943820

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 9, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7096/index.html

Built with commit: 1d8c28e4e4660639b4d6e6256ab9ddc2d4943820

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 9, 2021 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7096/index.html

Built with commit: 1d8c28e4e4660639b4d6e6256ab9ddc2d4943820

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 9, 2021 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7096/index.html

Built with commit: 1d8c28e4e4660639b4d6e6256ab9ddc2d4943820

@jeffchew
test(e2e): introduce cypress for react storybook
9cdb8d6
@jeffchew
Merge remote-tracking branch 'origin/test/e2e-web-components' into te…
1856a50 
…st/e2e-web-components

# Conflicts:
#	packages/tests-e2e/CHANGELOG.md
#	packages/tests-e2e/package.json
@jeffchew jeffchew changed the title test(e2e): introduce cypress for web components storybook test(e2e): introduce cypress for web components & react storybook Sep 9, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 9, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/7096/index.html

Built with commit: 1d8c28e4e4660639b4d6e6256ab9ddc2d4943820

emyarod
emyarod reviewed Sep 10, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be any lockfile and offline package mirror changes that go with this as well? I get unstaged changes when running a yarn install

@jeffchew
Copy link
Member Author

should there be any lockfile and offline package mirror changes that go with this as well? I get unstaged changes when running a yarn install

It should have been updated, but I can double-check. Web components and react are using existing dependencies for cypress already which is probably why there isn't much difference, but I would think that puppeteer would have been deleted.

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Sep 10, 2021
@jeffchew
Copy link
Member Author

@emyarod I ran a reset locally and didn't see any new changes. Did you run a reset on your end?

@emyarod
Copy link
Member

emyarod commented Sep 10, 2021

@jeffchew yeah mine is still running but I will update when it's finished

@emyarod
Copy link
Member

emyarod commented Sep 10, 2021 •
edited
Loading

@jeffchew hm yeah I still get unstaged changes after a reset

image

no idea why it installs correctly on master now but not after checking out the feature branch

@kodiakhq kodiakhq bot merged commit 97258d3 into carbon-design-system:master Sep 10, 2021
@jeffchew jeffchew deleted the test/e2e-web-components branch September 13, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod left review comments

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffchew @ibmdotcom-bot @emyarod @IgnacioBecerra