storage: use defer

carapace-sh · Sep 16, 2023 · fbb1cac · fbb1cac
1 parent f3f8d72
commit fbb1cac
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/storage.go b/storage.go
@@ -140,13 +140,16 @@ func (s _storage) getPositional(cmd *cobra.Command, index int) Action {
 func (s _storage) check() []string {
 	errors := make([]string, 0)
 	for cmd, entry := range s {
-		entry.flagMutex.RLock()
-		for name := range entry.flag {
-			if flag := cmd.LocalFlags().Lookup(name); flag == nil {
-				errors = append(errors, fmt.Sprintf("unknown flag for %s: %s\n", uid.Command(cmd), name))
+		func() {
+			entry.flagMutex.RLock()
+			defer entry.flagMutex.RUnlock()
+
+			for name := range entry.flag {
+				if flag := cmd.LocalFlags().Lookup(name); flag == nil {
+					errors = append(errors, fmt.Sprintf("unknown flag for %s: %s\n", uid.Command(cmd), name))
+				}
 			}
-		}
-		entry.flagMutex.RUnlock()
+		}()
 	}
 	return errors
 }