Swap out Rc
for Arc
to make stories thread-safe.
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this! I was looking for ways to use Twee files in Bevy. After using it in my build process to generate dialog clips from story files, I needed to load those stories as assets into the engine. Unfortunately, your use of
Rc
makesStory
non-threadsafe, so I couldn't add it as a Bevy asset.This PR swaps out your use of
Rc
withArc
. Haven't tested it yet, but it compiles, and I'm now able to work with stories as assets in Bevy.