Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BPOLY calibration option to CARACal #1433

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

rubyvanrooyen
Copy link
Collaborator

Updates and discussion as per Issue #1419

  • Add schema for BPOLY calibration parameters to crosscal_schema.yml
  • Update crosscal_worker.py to allow CASA BPOLY bandpass calibration option and sidestep issues due to change in cal table format

A sample configuration will be added later as part of a maser processing application example

@ratt-priv-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@bennahugo
Copy link
Collaborator

Do you want to initiate testing?

@paoloserra
Copy link
Collaborator

@SpheMakh this is still work in progress as some more development is needed to be able to apply the BPOLY solutions to the target in the current Caracal workflow. However, we've just agreed that it would be good if you could review the new bits of code already now. Thanks!

@paoloserra
Copy link
Collaborator

@SpheMakh kind reminder, we'd still a preliminary code review from you

@SpheMakh SpheMakh marked this pull request as draft April 3, 2023 08:41
@SpheMakh SpheMakh added this to the Busy week tasks milestone Apr 3, 2023
@SpheMakh SpheMakh marked this pull request as ready for review April 19, 2023 17:28
@SpheMakh
Copy link
Collaborator

Ready to test

@SpheMakh
Copy link
Collaborator

OK to test

@paoloserra
Copy link
Collaborator

@rubyvanrooyen can this be merged once updated to current master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants