Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull marquee stepping out of Redux #1063

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

captbaritone
Copy link
Owner

@captbaritone captbaritone commented Feb 11, 2021

Marquee stepping happens continuously at a relatively rapid frequency. Keeping this data in Redux means we need to run many selectors every time we step. By moving this state into React local state we can reduce the amount of work that is needed on each step.

@github-actions
Copy link

github-actions bot commented Feb 11, 2021

Size Change: -56 B (0%)

Total Size: 450 kB

Filename Size Change
./packages/webamp/built/webamp.bundle.min.js 272 kB -31 B (0%)
./packages/webamp/built/webamp.lazy-bundle.min.js 178 kB -25 B (0%)

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant