Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: mention master branch deprecation #1792

Merged
merged 1 commit into from
Nov 13, 2021
Merged

readme: mention master branch deprecation #1792

merged 1 commit into from
Nov 13, 2021

Conversation

tmfink
Copy link
Contributor

@tmfink tmfink commented Nov 11, 2021

Refers users to the next branch

Helps bring #1781 to a close

@tmfink
readme: mention master branch deprecation
47dd32c 
Refers users to the next branch
@kabeor
Copy link
Member

kabeor commented Nov 12, 2021

I suggest move this as a PR template. And master 'deprecated' may cause some misunderstands, it will rename as v4 in the future.

@tmfink
Copy link
Contributor Author

tmfink commented Nov 12, 2021

@kabeor A PR template is a good idea, but we also want folks to get the message if they already have a master checkout.

There is already a v4 branch, so I don't think master branch has much of a purpose (see #1781 for details).

@kabeor
Copy link
Member

kabeor commented Nov 13, 2021

v4 branch is 141 commits ahead, 306 commits behind master.
so we will merge master to v4 finally.

Merge for now as a hint

@kabeor kabeor merged commit 0344e13 into capstone-engine:master Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmfink @kabeor