Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3PH part 1: Prepare for 3PH support #594

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Semisol
Copy link

@Semisol Semisol commented Oct 12, 2024

This PR does not implement any 3PH related functionality, except preparations:

  • A new Network3PH interface has been added to be implemented by networks supporting 3PH. (this could be named better)
  • 3PH-related methods have been moved out of Network for networks that do not support it.
  • Schemas have been updated to match the capnproto/capnproto repository.

To be done:

  • Initial 3PH support, with forwarding and Resolve with 3rd party capabilities
  • Embargo support for 3PH
  • An extension to the API that allows tail calls (This is not going to be a priority for me, as it is only useful in rare conditions)

@lthibault
Copy link
Collaborator

lthibault commented Oct 15, 2024

Thanks for the contribution!
I think there's a dependency issue causing CI to fail. I had a look in the meantime, and it LGTM overall. Let's get CI passing and then merge it in.

@Semisol
Copy link
Author

Semisol commented Oct 16, 2024

The automatic schema generator seems to not be able to handle the case of schemas in directories, with compat/ as an example. I'll push an update that fixes this.

This commit fixes the package names generated by `gen.sh import`,
and removes `json-test.capnp` as it is unnecessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants