Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add built-in and Helm storage Types, adjust validation manifests #57

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Add built-in and Helm storage Types, adjust validation manifests #57

merged 2 commits into from
Feb 17, 2022

Conversation

mszostok
Copy link
Member

Description

Changes proposed in this pull request:

  • Add built-in and Helm storage Types, adjust validation manifests

Tested by e2e test on capactio/capact#630

Related issue(s)

@mszostok mszostok added enhancement New feature or request area/hub-manifests Relates to Hub manifests labels Feb 11, 2022
@mszostok mszostok mentioned this pull request Feb 11, 2022
Merged
@mszostok mszostok mentioned this pull request Feb 13, 2022
Closed
pkosiec
pkosiec approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 comment

manifests/core/type/hub/storage/neo4j.yaml Outdated Show resolved Hide resolved
@mszostok mszostok merged commit d7034a0 into capactio:main Feb 17, 2022
@mszostok mszostok deleted the policy-syntax/type-instances branch February 17, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@tmitchell tmitchell Awaiting requested review from tmitchell tmitchell is a code owner

@mkuziemko mkuziemko Awaiting requested review from mkuziemko mkuziemko is a code owner

Assignees
No one assigned
Labels
area/hub-manifests Relates to Hub manifests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec