fix: ensure imeHeight is always positive
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the imeHeight is always positive. This will keep the activity above or at the bottom of the decor view
|
@tafelnl Please review this. Thanks you! |
|
Is this repo still being maintained? |
tafelnl
reviewed
Sep 4, 2024
android/src/main/java/com/getcapacitor/community/safearea/SafeArea.kt
Outdated
Show resolved
Hide resolved
tafelnl
changed the title
imeHeight is always positive
tafelnl
approved these changes
Sep 6, 2024
|
Good catch, and thanks for submitting this fix! |
|
This update breaks the plugin for me. When the keyboard is open, it overlaps the bottom edge of the app for a number of pixels that appears to match the height of the |
|
Same issue |
|
I filed a bug report with a screenshot. See #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the imeHeight is always positive. This will keep the activity above or at the bottom of the decor view
This should fix issue #24.