Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ssr compatibility #49

Merged
merged 2 commits into from
Aug 12, 2024
Merged

fix: fix ssr compatibility #49

merged 2 commits into from
Aug 12, 2024

Conversation

sabereen
Copy link
Contributor

In SSR compatible projects, we cannot use web-only APIs directly (etc. navigator). So, such projects cannot use this plugin. This PR fixes this issue.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.

@robingenz
Copy link
Member

Please run "npm run fmt" to format the code.

@sabereen
Copy link
Contributor Author

done

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@robingenz robingenz merged commit 55b23cd into capacitor-community:master Aug 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants