支持external指标 (#46)

caoyingjunz · Nov 21, 2024 · 1194c4c · 1194c4c
1 parent abc8760
commit 1194c4c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pkg/controller/controller_utils.go b/pkg/controller/controller_utils.go
@@ -258,8 +258,8 @@ func parseMetricSpecForPrometheus(target string, metricType string, metricValue
 	}
 
 	metricSpec := autoscalingv2.MetricSpec{
-		Type: autoscalingv2.PodsMetricSourceType,
-		Pods: &autoscalingv2.PodsMetricSource{
+		Type: autoscalingv2.ExternalMetricSourceType,
+		External: &autoscalingv2.ExternalMetricSource{
 			Metric: autoscalingv2.MetricIdentifier{
 				Name: name,
 			},
@@ -271,9 +271,9 @@ func parseMetricSpecForPrometheus(target string, metricType string, metricValue
 
 	switch target {
 	case targetAverageUtilization:
-		metricSpec.Pods.Target.Type = autoscalingv2.UtilizationMetricType
+		metricSpec.External.Target.Type = autoscalingv2.UtilizationMetricType
 	case targetAverageValue:
-		metricSpec.Pods.Target.Type = autoscalingv2.AverageValueMetricType
+		metricSpec.External.Target.Type = autoscalingv2.AverageValueMetricType
 	}
 
 	return metricSpec, nil

diff --git a/pkg/controller/types.go b/pkg/controller/types.go
@@ -36,7 +36,7 @@ const (
 	memoryAverageUtilization     = "memory." + PixiuRootPrefix + PixiuSeparator + targetAverageUtilization
 	prometheusAverageUtilization = "prometheus." + PixiuRootPrefix + PixiuSeparator + targetAverageUtilization
 
-	// 指标来着 prometheus 时，需要指定指标名称
+	// 指标来自 prometheus 时，需要指定指标名称
 	prometheusCustomMetric = PixiuRootPrefix + PixiuSeparator + "targetCustomMetric"
 
 	// CPU, in cores. (500m = .5 cores)