Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable JRuby's Variable Sharing feature #715

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

disable JRuby's Variable Sharing feature #715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/edu/illinois/library/cantaloupe/delegate/JRubyDelegateProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import org.slf4j.LoggerFactory;

import javax.script.Invocable;
import javax.script.ScriptContext;
import javax.script.ScriptEngine;
import javax.script.ScriptEngineManager;
import javax.script.ScriptException;
Expand Down Expand Up @@ -71,6 +72,14 @@ final class JRubyDelegateProxy implements DelegateProxy {
System.setProperty("org.jruby.embed.localvariable.behavior", "transient");

scriptEngine = new ScriptEngineManager().getEngineByName("jruby");

// Workaround for a memory leak in JRuby's BiVariableMap: By default, all
// instance variables are stored into BiVariableMap so they are accessible
// from Java. However, there is currently no mechanism for ever removing
// them, forming a memory leak.
// That feature isn't used by Cantaloupe, so we can just disable it.
scriptEngine.getContext().setAttribute("org.jruby.embed.sharing.variables",
false, ScriptContext.ENGINE_SCOPE);
}

/**
Expand Down
Loading