i/ppa: Improve/Fix GPG tmp directory #258
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
- Coverage 93.96% 93.68% -0.28%
==========================================
Files 18 18
Lines 3429 4371 +942
==========================================
+ Hits 3222 4095 +873
- Misses 133 205 +72
+ Partials 74 71 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@AristoChen Feel free to take a look and even try it if you can. |
|
Thanks for letting me know! I will find some time to test, and may I know where can I download the snap built by the github CI? |
|
It's built in the "Tests" workflow. The current last run is https://github.com/canonical/ubuntu-image/actions/runs/11382537094 |
|
tested with a path |
|
Hi @upils May I know when will you merge this PR? thanks! |
Signed-off-by: Paul Mars <[email protected]>
Rework createTmpGPGDir so the temp dir provided to GPG is in the OS-chosen temp directory. This should very likely always be a short directory and so should not be an issue for the socket name used to communicate with dirmngr. Also make sure we "hook" the call to os.MkdirTemp in tests so the temp dir is in fact created in the temp directory dedicated to the test (and cleaned up at the end). This *may* break if tests are run from of deep directory. Fixes: LP: #2057885 Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
|
@AristoChen This is now merged. In a couple of hours you should be able to use the snap from |
Rework createTmpGPGDir so the temp dir provided to GPG is in the OS-chosen temp directory. This should very likely always be a short directory and so should not be an issue for the socket name used to communicate with dirmngr.
Also stop using deprecated --secret-keyring on gpg.
Closes: LP: #2057885
Fixes: FR-7372