Clean /dev/, /run/, /sys/ #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some files (links, character devices, etc.) were left over in the /dev/ and were causing issues when booting or when the resulting chroot was moved around by Imagecraft (refusing to move named pipes). Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
- Coverage 94.12% 93.99% -0.14%
==========================================
Files 18 18
Lines 3404 3412 +8
==========================================
+ Hits 3204 3207 +3
- Misses 127 132 +5
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I think |
|
I hope we're not dropping files in /sys! |
|
No files, but: After unpacking a freshly built tarball. EDIT: This also looks wrong |
|
Sigh. Yes agree it would be good to clean those up! |
|
I also spotted these dirs but was unsure it was safe to remove the directory structure under them. Let's clean them too then! |
Signed-off-by: Paul Mars <[email protected]>
tobhe
approved these changes
Aug 8, 2024
mwhudson
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some files (links, character devices, etc.) were left over in the
/dev/and were causing issues when booting or when the resulting chroot was moved around by Imagecraft (refusing to move named pipes). Also clean/run/and/sys/.