Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note to run u-i as root or with sudo #224

Merged
merged 2 commits into from
May 23, 2024
Merged

Add a note to run u-i as root or with sudo #224

merged 2 commits into from
May 23, 2024

Conversation

upils
Copy link
Collaborator

@upils upils commented May 3, 2024

No description provided.

@upils upils self-assigned this May 3, 2024
@upils upils force-pushed the use-root-or-sudo branch from 731d030 to d225f2c Compare May 3, 2024 09:55
@upils upils requested a review from rkratky May 3, 2024 09:56
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.27%. Comparing base (2202fe9) to head (81a74dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   94.27%   94.27%           
=======================================
  Files          16       16           
  Lines        3284     3284           
=======================================
  Hits         3096     3096           
  Misses        120      120           
  Partials       68       68           
Flag Coverage Δ
unittests 94.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but of course we probably should consult with Robert.

@upils
Copy link
Collaborator Author

upils commented May 16, 2024

LGTM, but of course we probably should consult with Robert.

Robert already reviewed it. See above.

@upils upils force-pushed the use-root-or-sudo branch from 81a74dc to ba7cf4c Compare May 23, 2024 14:25
@upils upils merged commit d5c688d into main May 23, 2024
6 of 10 checks passed
@upils upils deleted the use-root-or-sudo branch June 18, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants