Fix calculation of sizes and offset #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let snapd calculate minimal image size and offsets instead of doing it from ubuntu-image code.
alfonsosanchezbeato
force-pushed
the
fix-size-calculations
branch
from
1902156 to
7e3a54d
Compare
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 90.44% 90.47% +0.03%
==========================================
Files 11 11
Lines 2449 2457 +8
==========================================
+ Hits 2215 2223 +8
Misses 208 208
Partials 26 26
|
upils
reviewed
Oct 17, 2023
| // last one in gadget.yaml). Note that we only have one volume | ||
| // (see check above). | ||
| var yamlIndex int | ||
| for _, vol := range stateMachine.GadgetInfo.Volumes { |
There was a problem hiding this comment.
Just below we use a different heuristic to get the last volume stateMachine.GadgetInfo.Volumes[lastVolumeName].Structure
We should probably pick one and use it at both places.
There was a problem hiding this comment.
Very good point, I hadn't noticed that. I've shuffled code a bit, as I don't think we need lastVolumeName even.
alfonsosanchezbeato
force-pushed
the
fix-size-calculations
branch
from
7e3a54d to
7bc6883
Compare
alfonsosanchezbeato
force-pushed
the
fix-size-calculations
branch
from
7bc6883 to
a1ef96a
Compare
sil2100
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let snapd calculate minimal image size and offsets instead of doing it from ubuntu-image code.