-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR-5570 - Support the keep-enabled parameter in ubuntu-image extra-ppas #150
Conversation
56b47ca
to
3276cb5
Compare
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
==========================================
- Coverage 90.58% 90.48% -0.10%
==========================================
Files 13 13
Lines 2516 2533 +17
==========================================
+ Hits 2279 2292 +13
- Misses 210 214 +4
Partials 27 27
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally +1 on the changes, good test coverage. Changes themselves solid and that's the way to go. Included two small changes, but nothing too critical.
615679d
to
73ec099
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'll bump the version and changelog and then merge (after tests finish running).
To use newly testing object this PR is rebased on https://github.com/canonical/ubuntu-image/tree/add-pack-feature.