Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require the cloud-config header for meta-data and network-config #149

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

sil2100
Copy link
Contributor

@sil2100 sil2100 commented Oct 5, 2023

I got reports that people now have issues building image as we became a bit too strict. Tried finding in cloud-init documentation if the #cloud-config header is needed for other than user-data, but didn't see anything. And truth is that it seems to work as-is when they don't.

I think it makes sense to, for now, be less strict and merge this to at least not break existing users.

@sil2100 sil2100 requested a review from upils October 5, 2023 17:00
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #149 (75bac4a) into main (6193013) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   89.17%   89.17%           
=======================================
  Files          11       11           
  Lines        2449     2449           
=======================================
  Hits         2184     2184           
  Misses        244      244           
  Partials       21       21           
Files Coverage Δ
internal/statemachine/classic_states.go 97.86% <100.00%> (ø)

@upils
Copy link
Collaborator

upils commented Oct 6, 2023

LGTM. I took a look at the cloud-init code and indeed it seems that only the user data requires the #cloud-config header (see https://cloudinit.readthedocs.io/en/latest/explanation/format.html)

@upils upils merged commit 75b6c0a into main Oct 6, 2023
11 of 12 checks passed
@upils upils deleted the only-user-config branch February 13, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants