Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: migrate to core24 #177

Merged
merged 7 commits into from
May 6, 2024
Merged

snap: migrate to core24 #177

merged 7 commits into from
May 6, 2024

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Apr 15, 2024

No description provided.

@Saviq Saviq force-pushed the core24 branch 5 times, most recently from 18a7839 to 3c8e8b9 Compare April 15, 2024 13:26
@Saviq Saviq force-pushed the core24 branch 2 times, most recently from 1f742f3 to 3169a91 Compare April 24, 2024 12:54
@Saviq Saviq added the no merge label Apr 24, 2024
@Saviq Saviq marked this pull request as ready for review April 24, 2024 14:30
@Saviq Saviq requested a review from a team as a code owner April 24, 2024 14:30
@Saviq Saviq requested a review from AlanGriffiths April 24, 2024 14:30
@AlanGriffiths
Copy link
Contributor

There is a problem with the fonts:

Mir fatal error: Loading font from /usr/share/fonts/truetype/ubuntu/Ubuntu-R.ttf

Which is because, shelled into the core24 build of Frame:

$ realpath /usr/share/fonts/truetype/ubuntu/Ubuntu-R.ttf
/usr/share/fonts/truetype/ubuntu/Ubuntu[wdth,wght].ttf
$ ls -lh "/usr/share/fonts/truetype/ubuntu/Ubuntu[wdth,wght].ttf"
ls: cannot access '/usr/share/fonts/truetype/ubuntu/Ubuntu[wdth,wght].ttf': No such file or directory

(Not sure what should be going on there, but Frame fails to load a font from a broken link)

@Saviq Saviq force-pushed the core24 branch 2 times, most recently from ac5601a to 2d524b3 Compare April 29, 2024 13:57
@Saviq
Copy link
Collaborator Author

Saviq commented Apr 29, 2024

(Not sure what should be going on there, but Frame fails to load a font from a broken link)

Fixed

Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about file renames here

snap/snapcraft.yaml Show resolved Hide resolved
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frame-diagnostic doesn't appear to be working for me. It is working on core22 though, but perhaps I'm missing something. Here are my steps:

  1. Build the ubuntu-frame snap
  2. sudo snap install --dangerous ...
  3. Run ubuntu-frame (hosted on X)
  4. Run diagonstic-frame and see the following:
$ sudo frame-diagnostic "Hello, world"
/snap/frame-diagnostic/10/write-diagnostic: 2: cannot create /var/snap/frame-diagnostic/common/diagnostic/diagnostic.txt: Directory nonexistent

Am I missing anything there?

@Saviq
Copy link
Collaborator Author

Saviq commented May 6, 2024

  1. Build the ubuntu-frame snap
  2. sudo snap install --dangerous ...

This is better:

snap install ubuntu-frame --channel 24/edge/pr177
  1. Run ubuntu-frame (hosted on X)
  2. Run diagonstic-frame and see the following:
$ sudo frame-diagnostic "Hello, world"
/snap/frame-diagnostic/10/write-diagnostic: 2: cannot create /var/snap/frame-diagnostic/common/diagnostic/diagnostic.txt: Directory nonexistent

Am I missing anything there?

Works for me, though you need to stick to the same user (if you used it as $USER, sudo won't work, and vice versa).

@Saviq Saviq requested a review from mattkae May 6, 2024 16:13
@AlanGriffiths
Copy link
Contributor

Am I missing anything there?

snap connections frame-diagnostic?

Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diagnostics worked! My bad

@mattkae mattkae added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit a978d46 May 6, 2024
3 checks passed
@mattkae mattkae deleted the core24 branch May 6, 2024 17:28
github-merge-queue bot pushed a commit to canonical/mir-ci that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants