Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding dss deployment on EC2 #302
adding dss deployment on EC2 #302
Changes from all commits
2cfbe35
ef725f9
8f9721e
f87db7c
60994e9
db00f3d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would prefer to reference the official DSS docs for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TLDR; I'll leave that to @k-dimple
In a conversation with another team (Anbox), we were discussing how referencing other guides sometimes impacted the experience, as a 1/the official guides tend to be more generic and sometimes confuse the customer with other things, and 2/ the How-to stops to be a straightforward recipe.
The documentation person there told me that they are trying now to have self-sufficient guides for that reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree with the argument. If the whole how-to guide was just about installing DSS, we could have directly pointed to the DSS docs. Here since we are talking about specific EC2 instances and including specific drivers, it is better to give a complete set of instructions and to point them to the DSS docs for further reference. (Carlos has already done this by adding a link in the introduction section.) So I think we can keep it in its current state.