restart on traefik-route initiated static config changes #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroPasotti
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
lucabello,
mmkay,
sed-i and
simskij
as code owners
mmkay
reviewed
Apr 22, 2024
🤦 Co-authored-by: Mateusz Kulewicz <[email protected]>
…aefik-k8s-operator into traefik-route-static-config
…aefik-k8s-operator into traefik-route-static-config
lucabello
approved these changes
Apr 24, 2024
|
CI is stuck because of microsoft/linux-package-repositories#130 now trying to run them locally, if they pass I vote we merge on red |
|
only test failing locally is unrelated to these changes. (it's on forward-auth) |
mmkay
approved these changes
Apr 24, 2024
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a 'static' field to the traefik-route interface and instructs Traefik to take whatever's in there and put it into the static config and restart itself whenever there's a change.