-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISD-2817 Add mas to pebble plan #620
base: 2/main
Are you sure you want to change the base?
Conversation
…l/synapse-operator into install_mas_cli_in_synapse_rock
…l/synapse-operator into install_mas_cli_in_synapse_rock
…-operator into add_mas_to_pebble_plan
container: Synapse container. | ||
""" | ||
command = [MAS_EXECUTABLE_PATH, "config", "check", "-c", MAS_CONFIGURATION_PATH] | ||
process = container.exec(command=command, working_dir=MAS_WORKING_DIR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should wrap the pebble exec error into a business error, same comment for sync_mas_config
username, | ||
] | ||
|
||
process = container.exec(command=command, working_dir=MAS_WORKING_DIR, combine_stderr=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should wrap pebble exec error
Considering a refresh/upgrade scenario where Mjolnir was enabled, should the charm delete the previously created management room (also the rate limit configuration or anything related to mjolnir)? synapse-operator/src/mjolnir.py Line 214 in 435a99d
|
@amandahla We don't support automatic upgrade from older revisions to avoid the complexity related to migration of SAML users to OIDC in MAS (which involves modifying the |
Test coverage for 2d02ad7
Static code analysis report
|
|
||
For more details and implementation guidance, refer to the [Mjolnir GitHub repository](https://github.com/matrix-org/mjolnir). | ||
|
||
With the arrival of MAS mjolnir has been temporary disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding what we discussed about refresh, can you add a note here in the doc about manually removing what was created?
This PR adds a pebble layer that starts the Matrix Authentication Service:
msc3861
config to activate MASregister-user
action and add a newverify-user-email
action based on the mas-cli❗This PR also removes support for mjolnir. As it is currently incompatible with MAS.
Mjolnir relies on synapse's
/_synapse/admin/v1/users/:user_id/admin
API for most of its commands (ref: https://github.com/matrix-org/mjolnir/blob/a7f49b816022112a78ea35a2e30a06092e77c2eb/src/Mjolnir.ts#L528) which has been disabled in MAS as per this PR : matrix-org/synapse#15582Checklist
src-docs
urgent
,trivial
,complex
)