fix: pr feedback

canonical · Nov 15, 2024 · e8b4a5c · e8b4a5c
1 parent 4eafed7
commit e8b4a5c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/.github/workflows/lint-python.yaml b/.github/workflows/lint-python.yaml
@@ -1,4 +1,4 @@
-name: Lint
+name: Lint Python
 on:
   workflow_call:
   # Because we have a uv.lock file, we can also use this workflow to lint ourselves.

diff --git a/.github/workflows/self-test-qa.yaml b/.github/workflows/self-test-qa.yaml
@@ -16,4 +16,4 @@ jobs:
       fast-test-python-versions: '["3.14"]'
       slow-test-platforms: '["ubuntu-latest"]'
       slow-test-python-versions: '["3.14"]'
-      lowest-python-version: '["3.0"]'
+      lowest-python-version: '3.0'
diff --git a/.github/workflows/test-python.yaml b/.github/workflows/test-python.yaml
@@ -3,19 +3,16 @@ on:
   workflow_call:
     inputs:
       fast-test-platforms:
-        required: false
         type: string
         default: '["jammy", "noble"]'
         description: |
           The platforms to run fast tests on, as a JSON array.
       fast-test-python-versions:
-        required: false
         type: string
         default: '["3.10", "3.11", "3.12", "3.13"]'
         description: |
           The python versions to run fast tests on, as a JSON array.
       lowest-python-version:
-        required: false
         type: string
         description: |
           The Python version to run when using "lowest" resolution for tests.
@@ -25,7 +22,6 @@ on:
         description: |
           The platforms to run slow tests on, as a JSON array.
       slow-test-python-versions:
-        required: false
         type: string
         default: '["3.10"]'
         description: |
@@ -104,7 +100,7 @@ jobs:
       - name: Upload test coverage
         uses: actions/upload-artifact@v4
         with:
-          name: coverage-lowest
+          name: coverage-lowest-py${{ inputs.lowest-python-version }}
           overwrite: true
           path: |
             ./coverage.xml