Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typos in doc and make files #287

Merged
merged 5 commits into from
Dec 9, 2024
Merged

fix: Typos in doc and make files #287

merged 5 commits into from
Dec 9, 2024

Conversation

upils
Copy link
Contributor

@upils upils commented Dec 4, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Several small issues found when recently using starbase to init a project.

@upils upils self-assigned this Dec 4, 2024
@upils upils changed the title Work/incorrect make help fix: Typos in doc and make files Dec 4, 2024
@upils
Copy link
Contributor Author

upils commented Dec 4, 2024

Waiting for #288 to pass the currently failing linter check.

@upils upils force-pushed the work/incorrect-make-help branch 3 times, most recently from 5ab7d3f to 1d11d5f Compare December 4, 2024 13:57
README.rst Outdated Show resolved Hide resolved
@upils upils force-pushed the work/incorrect-make-help branch from 1d11d5f to 3c899bc Compare December 9, 2024 08:17
upils added 4 commits December 9, 2024 10:15
When creating a new project make it clear that the history must be synced with the starbase one.

Signed-off-by: Paul Mars <[email protected]>
When 2 targets are define on the same line in the Makefile, the `make help` command does not properly parse the line and display the ##- prefix.

Limit ourselves to a single name per target to keep the help generation
fairly simple.

Signed-off-by: Paul Mars <[email protected]>
@upils upils force-pushed the work/incorrect-make-help branch from 3c899bc to ba2d4b7 Compare December 9, 2024 09:15
@upils upils marked this pull request as ready for review December 9, 2024 10:11
@upils upils requested a review from lengau December 9, 2024 10:11
@lengau lengau merged commit 2a0a524 into main Dec 9, 2024
8 of 9 checks passed
@lengau lengau deleted the work/incorrect-make-help branch December 9, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants