-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use starflow CI actions #272
Conversation
ee226e5
to
dff7074
Compare
@lengau I think I'll do the review starting from the final UI; let me know if this is too unreadable: |
also @lengau can you break a test so we see what a failed run looks like? |
Suggestion from canonical/starbase#272
@tigarmo thanks for the review! For the questions you asked:
|
238caed
to
d60eb95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
ba9902d
to
8c4c2dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for a small comment on the uv.lock
file.
e85fcf4
to
19d6db0
Compare
19d6db0
to
e14ed2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
0c59109
to
c4b044e
Compare
1f6ab74
to
b6cfdba
Compare
b6cfdba
to
1029c2b
Compare
887731a
to
65ae46a
Compare
65ae46a
to
39a13f0
Compare
39a13f0
to
f0cd563
Compare
tox
?CRAFT-3603
Depends on canonical/starflow#18