Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use starflow CI actions #272

Merged
merged 17 commits into from
Nov 18, 2024
Merged

ci: use starflow CI actions #272

merged 17 commits into from
Nov 18, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Oct 22, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

CRAFT-3603

Depends on canonical/starflow#18

.github/workflows/qa.yaml Outdated Show resolved Hide resolved
.github/workflows/qa.yaml Outdated Show resolved Hide resolved
.github/workflows/qa.yaml Outdated Show resolved Hide resolved
.github/workflows/qa.yaml Outdated Show resolved Hide resolved
@lengau lengau force-pushed the work/starflow-lint branch 5 times, most recently from ee226e5 to dff7074 Compare October 22, 2024 22:45
.github/workflows/docs.yaml Outdated Show resolved Hide resolved
@lengau lengau marked this pull request as ready for review October 22, 2024 22:46
@lengau lengau requested review from tigarmo and mattculler October 22, 2024 22:46
@tigarmo
Copy link
Contributor

tigarmo commented Oct 23, 2024

@lengau I think I'll do the review starting from the final UI; let me know if this is too unreadable:
image

@tigarmo
Copy link
Contributor

tigarmo commented Oct 23, 2024

also @lengau can you break a test so we see what a failed run looks like?

lengau added a commit to lengau/starflow that referenced this pull request Oct 23, 2024
@lengau
Copy link
Contributor Author

lengau commented Oct 23, 2024

@tigarmo thanks for the review!

For the questions you asked:

  1. I can name the step whatever I want, so I can do that. (commit incoming)
  2. I don't think I can hide that output in a composite action. The only way I can see being able to do it is by putting it into a separate step in a reusable workflow. I'm not sure I'm particularly happy with the reusable workflow I came up with for this earlier though: https://github.com/canonical/starflow/pull/10/files
  3. I'm trying a notice message - not sure whether it'll work, will report back.
  4. While this isn't a broken test (it was broken coverage), this has the same effect: https://github.com/canonical/starbase/actions/runs/11469498939/job/31916844851

.github/workflows/qa.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@mattculler mattculler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@lengau lengau force-pushed the work/starflow-lint branch from ba9902d to 8c4c2dc Compare October 28, 2024 21:19
@lengau lengau requested review from upils and tigarmo October 29, 2024 08:18
pyproject.toml Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@lengau lengau requested a review from tigarmo November 1, 2024 09:14
Copy link
Contributor

@upils upils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a small comment on the uv.lock file.

uv.lock Outdated Show resolved Hide resolved
@lengau lengau force-pushed the work/starflow-lint branch from e85fcf4 to 19d6db0 Compare November 12, 2024 18:18
@lengau lengau force-pushed the work/starflow-lint branch from 19d6db0 to e14ed2c Compare November 12, 2024 18:22
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@lengau lengau force-pushed the work/starflow-lint branch from 0c59109 to c4b044e Compare November 12, 2024 18:38
@lengau lengau force-pushed the work/starflow-lint branch from 1f6ab74 to b6cfdba Compare November 13, 2024 19:14
@lengau lengau force-pushed the work/starflow-lint branch from b6cfdba to 1029c2b Compare November 15, 2024 19:13
.github/workflows/policy.yaml Outdated Show resolved Hide resolved
.github/workflows/qa.yaml Outdated Show resolved Hide resolved
@lengau lengau force-pushed the work/starflow-lint branch from 887731a to 65ae46a Compare November 18, 2024 16:32
@lengau lengau force-pushed the work/starflow-lint branch from 65ae46a to 39a13f0 Compare November 18, 2024 16:50
@lengau lengau force-pushed the work/starflow-lint branch from 39a13f0 to f0cd563 Compare November 18, 2024 16:51
@lengau lengau merged commit a411e24 into main Nov 18, 2024
11 checks passed
@lengau lengau deleted the work/starflow-lint branch November 18, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants