Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add common words into wordlist #152

Merged
merged 2 commits into from
Dec 8, 2023
Merged

add common words into wordlist #152

merged 2 commits into from
Dec 8, 2023

Conversation

tang-mm
Copy link
Contributor

@tang-mm tang-mm commented Dec 7, 2023

No description provided.

.wordlist.txt Outdated
Grafana
hostname
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep that one out - is it "hostname" or "host name"? For LXD, I insist on "host name".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it depends - when calling something in code, it's usually hostname but then it's excluded from the spelling checks by virtue of being in a code block. I tend to use host name in body text, but if I have to use hostname I put it in backticks (for example, if I'm referring to a code snippet)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's exactly how I do it as well.
I don't mind other projects allowing "hostname" in body text as well, but then it needs to go into the custom word list. ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing it! I removed it from the list :)

.wordlist.txt Outdated
IAM
installable
JSON
Juju
Kubernetes
Kubeflow
LaunchPad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen Launchpad with the P capitalised before. I think it should be just Launchpad as used on the https://launchpad.net/ website?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

@tang-mm tang-mm requested review from s-makin and ru-fu December 8, 2023 06:03
Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tang-mm tang-mm merged commit e37989c into main Dec 8, 2023
2 of 3 checks passed
@tang-mm tang-mm deleted the wordlist branch December 8, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants