Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'help' target #123

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix 'help' target #123

merged 1 commit into from
Oct 9, 2023

Conversation

rkratky
Copy link
Contributor

@rkratky rkratky commented Oct 5, 2023 •
edited
Loading

Fixes #122

This adds:

  • Sourcing of the activate script in the command of the help target, so that the sphinx-build script is in the PATH and can be executed.
  • The $(VENVDIR) target as a prereq to the help target, so that make help doesn't fail when run without some other target first creating the virt. env.

@rkratky rkratky added the bug Something isn't working label Oct 5, 2023
ru-fu
ru-fu approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ru-fu ru-fu merged commit 50baf2b into canonical:main Oct 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ru-fu ru-fu ru-fu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Target 'help' doesn't work (without venv)
2 participants
@rkratky @ru-fu