Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit 1 on failure #120

Closed
wants to merge 0 commits into from
Closed

Conversation

ColmBhandal
Copy link
Contributor

@ColmBhandal ColmBhandal commented Oct 3, 2023

Causes a non-zero exit status when there are woke findings. This in turn will fix the issue with failure reporting on the documentation GitHub workflow: canonical/documentation-workflows#5 (comment).

To test:

  1. Checkout main branch
  2. Edit some file to include a disallowed word (e.g. edit readme.rst by adding "master")
  3. Run make woke
  4. Observe that there is a "finding" reported by woke, warning of the use of the disallowed word
  5. Run echo $? immediately afterwards - it should output 0, indicating successful exit status

Repeat the above steps again on this branch. Notice that the command exits with non-zero exit status this time.

@ColmBhandal ColmBhandal requested a review from ru-fu October 3, 2023 12:29
@ru-fu ru-fu closed this Oct 3, 2023
@ru-fu ru-fu force-pushed the 119-exit-on-fail branch from 26a20f9 to 8f7cba2 Compare October 3, 2023 14:07
@ru-fu
Copy link
Contributor

ru-fu commented Oct 3, 2023

Oops, that push was supposed to go to my testing branch, not yours ... ;)
But the good thing is, the test did what it was supposed to: https://github.com/ru-fu/starter-pack/actions/runs/6394238933/job/17355202715

Sorry for messing up your branch, and no clue why I could push before but not now. You could try just force-pushing your branch again (without fetching any updates).
Otherwise, I still have your commit, you could cherry-pick it in again or I can open a new PR ...
main...ru-fu:starter-pack:119-exit-on-fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants