Add sorting by creation date option (#164)

* added possibility to sort by creation date * add accuracy to the spec time
canonical · Dec 7, 2023 · 30d6b17 · 30d6b17
1 parent a55ff94
commit 30d6b17
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/client/Filters.tsx b/client/Filters.tsx
@@ -93,6 +93,7 @@ const Filters = ({
         id="sortBy"
         options={[
           { value: "date", label: "Last modified" },
+          { value: "created", label: "Create date" },
           { value: "name", label: "Name" },
           { value: "index", label: "Spec index" },
         ]}

diff --git a/client/UserFilterOptions.ts b/client/UserFilterOptions.ts
@@ -52,6 +52,8 @@ export function useFilteredAndSortedSpecs(specs: Spec[]) {
     if (by === "date") {
       key = "lastUpdated";
       direction = -1;
+    } else if (by === "created") {
+      key = "created";
     } else if (by === "name") {
       key = "title";
     } else if (by === "index") {

diff --git a/client/tests/Filters.test.tsx b/client/tests/Filters.test.tsx
@@ -57,9 +57,11 @@ describe("renders filter component", () => {
     const sortOption1 = screen.getByText("Last modified") as HTMLOptionElement;
     const sortOption2 = screen.getByText("Name") as HTMLOptionElement;
     const sortOption3 = screen.getByText("Spec index") as HTMLOptionElement;
+    const sortOption4 = screen.getByText("Create date") as HTMLOptionElement;
     expect(sortOption1.selected).toBeTruthy();
     expect(sortOption2.selected).toBeFalsy();
     expect(sortOption3.selected).toBeFalsy();
+    expect(sortOption4.selected).toBeFalsy();
   });
 
   it("checks a spec status and type", () => {

diff --git a/webapp/build_specs.py b/webapp/build_specs.py
@@ -11,7 +11,7 @@ def get_value_row(row, type):
             if "formattedValue" in row:
                 return datetime.strptime(
                     row["formattedValue"], "%Y-%m-%dT%H:%M:%S.%fZ"
-                ).strftime("%d %b %Y")
+                ).strftime("%d %b %Y %H:%M")
         elif "userEnteredValue" in row:
             if "stringValue" in row["userEnteredValue"]:
                 return type(row["userEnteredValue"]["stringValue"])
@@ -20,6 +20,7 @@ def get_value_row(row, type):
 
     return ""
 
+
 def index_in_list(a_list, index):
     return index < len(a_list)