i/prompting: do not error when converting empty abstract perms to AA perms #14975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14975 +/- ##
=========================================
Coverage ? 78.03%
=========================================
Files ? 1143
Lines ? 152647
Branches ? 0
=========================================
Hits ? 119121
Misses ? 26188
Partials ? 7338
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sat Jan 25 02:48:45 UTC 2025 Failures:Preparing:
Executing:
Restoring:
|
ZeyadYasser
approved these changes
Jan 24, 2025
zyga
approved these changes
Jan 24, 2025
…perms It's reasonable that one might wish to convert an empty list of abstract permissions to AppArmor permissions, such as when one is constructing an allowed permissions set where all permissions are denied. It was incorrect to treat this as an error, and furthermore, the only current caller of `AbstractPermissionsToAppArmorPermissions` which actually uses the error value is in `requestprompts`, which logs a logger notice on an error. So we were getting false-positive errors in the journalctl log. This commit fixes that issue. Signed-off-by: Oliver Calder <[email protected]>
olivercalder
force-pushed
the
prompting-no-log-empty-response-permissions
branch
from
0da5340 to
edb36c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's reasonable that one might wish to convert an empty list of abstract permissions to AppArmor permissions, such as when one is constructing an allowed permissions set where all permissions are denied.
It was incorrect to treat this as an error, and furthermore, the only current caller of
AbstractPermissionsToAppArmorPermissionswhich actually uses the error value is inrequestprompts, which logs a logger notice on an error. So we were getting false-positive errors in the journalctl log. This commit fixes that issue.This addresses https://warthogs.atlassian.net/browse/SNAPDENG-31322