o/snapstate: put MaybeReboot edges on link-snap in AddLinkNewBaseOrKernel and LinkNewBaseOrKernel #14934
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14934 +/- ##
=========================================
Coverage ? 78.03%
=========================================
Files ? 1141
Lines ? 152583
Branches ? 0
=========================================
Hits ? 119072
Misses ? 26176
Partials ? 7335
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewphelpsj
added
the
Run nested
|
Mon Jan 27 18:36:24 UTC 2025 Failures:Executing:
Restoring:
|
|
@Meulengracht that edge is only used inside of |
Meulengracht
approved these changes
Jan 21, 2025
|
thanks |
pedronis
approved these changes
Jan 21, 2025
…rnel and LinkNewBaseOrKernel Sometimes during a remodel, we need to create link-snap tasks for snaps that are already installed, but not yet considered boot participants. These tasks were missing reboot boundaries, which caused the tasks to be marked as done before the reboot completed. tests/nested/manual/remodel-offline exhibits this behavior, where core22 already is installed, but not the model's base snap. The link-snap task that was created during the remodel was being marked as done before the reboot that the task triggers completed. With this change, the entire remodel change will not be marked as done until that link-snap task triggers is completed
andrewphelpsj
force-pushed
the
fix-remodel-link-not-waiting-for-reboot
branch
from
8eba504 to
a43d9ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes during a remodel, we need to create link-snap tasks for snaps that are already installed, but not yet considered boot participants. These tasks were missing reboot boundaries, which caused the tasks to be marked as done before the reboot completed.
tests/nested/manual/remodel-offline exhibits this behavior, where core22 already is installed, but not the model's base snap. The link-snap task that was created during the remodel was being marked as done before the reboot that the task triggers completed.
With this change, the entire remodel change will not be marked as done until that the link-snap task triggers is completed.