-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: add support to send notices #13791
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #13791 +/- ##
==========================================
- Coverage 78.86% 78.85% -0.01%
==========================================
Files 1043 1044 +1
Lines 134595 134617 +22
==========================================
+ Hits 106144 106154 +10
- Misses 21837 21845 +8
- Partials 6614 6618 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nitpick on documentation.
Do we need to document the public API endpoint on the forum?
This is intended to be only used through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0b3efd4
to
1a308fe
Compare
This is a backport from pebble: canonical/pebble#297 Signed-off-by: Zeyad Gouda <[email protected]>
1a308fe
to
fb66daa
Compare
This is a backport from pebble: canonical/pebble#297 to allow sending notices from snap command.
This is a building block for #13770 to allow snap run to record
snap-run-inhibit
commands.