Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: add support to send notices #13791

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

ZeyadYasser
Copy link
Contributor

This is a backport from pebble: canonical/pebble#297 to allow sending notices from snap command.

This is a building block for #13770 to allow snap run to record snap-run-inhibit commands.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 78.85%. Comparing base (ab996a0) to head (58c854d).

Files Patch % Lines
client/notices.go 72.72% 4 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13791      +/-   ##
==========================================
- Coverage   78.86%   78.85%   -0.01%     
==========================================
  Files        1043     1044       +1     
  Lines      134595   134617      +22     
==========================================
+ Hits       106144   106154      +10     
- Misses      21837    21845       +8     
- Partials     6614     6618       +4     
Flag Coverage Δ
unittests 78.85% <72.72%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedronis pedronis added this to the 2.63 milestone Apr 5, 2024
Copy link
Contributor

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nitpick on documentation.

Do we need to document the public API endpoint on the forum?

client/notices.go Outdated Show resolved Hide resolved
@ZeyadYasser
Copy link
Contributor Author

LGTM with one nitpick on documentation.

Do we need to document the public API endpoint on the forum?

This is intended to be only used through snap run, in fact we go through extra effort verify it is coming from snap run. I believe it is better to keep the endpoint undocumented until we add another generic notice type similar to custom notices in pebble.

Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is a backport from pebble:
canonical/pebble#297

Signed-off-by: Zeyad Gouda <[email protected]>
@ernestl ernestl merged commit 02908bc into canonical:master Apr 9, 2024
41 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants