Replace current_master for current_primary

[amandahla]

Issue

Charms using the Redis library that check for inclusive naming fail because of the word "master".

Solution

Replace current_master for current_primary

[zmraul]

This was done because Redis uses a "master-replica" naming scheme.

I would probably avoid changing it on a couple of places related to the lib, and then having the same concept still called "master" all over the charm. In any case, as Tom pointed out, primary is the more common name.

[amandahla]

I changed only the part related to the library because I was afraid of causing a big impact/too much to review.
I'll change it for primary!

[amandahla]

@zmraul I changed everything now

[delgod]

@amandahla, a huge thank you for the contribution! Really

Could you please make sure that the charm actually works after the changes?
also, could you make all the tests work?
We cannot merge PR with broken tests or code

[zmraul]

Thanks for the changes!

I'm not a 100% sure that I caught them all, but please do not change commands or outputs from commands sent/received from Redis or Sentinel.

[amandahla]

@amandahla, a huge thank you for the contribution! Really

Could you please make sure that the charm actually works after the changes? also, could you make all the tests work? We cannot merge PR with broken tests or code

Hi, unfortunately I believe the tests are failing for something not related to this PR:
This is setting to use agent version 2.9.43
https://github.com/canonical/redis-k8s-operator/blob/main/.github/workflows/ci.yaml#L42
Error message:
ERROR this client can only bootstrap 3.3 agents

[amandahla]

@amandahla, a huge thank you for the contribution! Really

Could you please make sure that the charm actually works after the changes? also, could you make all the tests work? We cannot merge PR with broken tests or code
@delgod
I give it a try anyway but no deal:
https://github.com/canonical/redis-k8s-operator/actions/runs/8005322711/job/21864500948?pr=78

[zmraul]

Thanks!
I'll take a look failures when I have a moment, as they seem unrelated to the charm itself.

[zmraul]

LIBPATCH on the lib will need updating to 6

[zmraul]

Hi @amandahla. Recent changes should fix the CI/tests. Please rebase on main and give it another try!

For the conflicting file, ci.yaml, the changes on main should be kept.