Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reliance on StoredState in relation library #74

Closed
mthaddon opened this issue Jul 7, 2023 · 2 comments · Fixed by #75
Closed

Remove reliance on StoredState in relation library #74

mthaddon opened this issue Jul 7, 2023 · 2 comments · Fixed by #75
Labels
bug Something isn't working

Comments

@mthaddon
Copy link
Contributor

mthaddon commented Jul 7, 2023

The current relation library for redis relies on StoredState (per this code you pass it into the RedisRequires constructor).

The juju documentation on StoredState says "charm authors should avoid state when they can". It would be great if the library could be updated to not rely on StoredState.

@mthaddon mthaddon added the bug Something isn't working label Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

@mthaddon
Copy link
Contributor Author

We've just seen a problem related to this in 3 of 8 production discourse instances after k8s workers were resized in a cluster. The units had the wrong IP in stored state even though the information was correct in the relation databag. We worked around it by entering a juju debug-code session and manually updating stored state. It would be much better if the relation library just inspected relation data directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant