-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new database interface for the postgresql relation #79
Conversation
1e43951
to
4ba3480
Compare
6b46c63
to
6479627
Compare
6479627
to
6236f02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Minor nitpicks as comments, would it be correct to assume that the stylistic issues are pretty hard to overcome at this stage of the charm?
Test coverage for 92ed5be
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - we'll want to update the docs to direct people to use this new relation and charm, but that can happen as a later step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I created a database.py module alongside the charm.
It uses the new postgresql_client interface.