Fix ingress usage #349
Merged
Fix ingress usage #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
commented
Sep 2, 2022
sed-i
requested review from
Abuelodelanada,
rbarry82,
balbirthomas,
dstathis and
simskij
as code owners
sed-i
force-pushed
the
feature/fix-ingress-usage
branch
from
46a0132 to
3b26882
Compare
sed-i
force-pushed
the
feature/fix-ingress-usage
branch
from
3b26882 to
0491636
Compare
dstathis
approved these changes
Sep 14, 2022
rbarry82
reviewed
Sep 16, 2022
rbarry82
reviewed
Sep 16, 2022
sed-i
force-pushed
the
feature/fix-ingress-usage
branch
from
480109b to
c82e646
Compare
Abuelodelanada
approved these changes
Sep 23, 2022
Fix reload under ingress Add positive assertion Do not use star notation for the self-scrape job Pass external hostname to MetricsEndpointProvider Fix reload Use update-status ass the refresh event Add test stubs
sed-i
force-pushed
the
feature/fix-ingress-usage
branch
from
b5846c1 to
6e9d4b5
Compare
Abuelodelanada
approved these changes
Oct 4, 2022
| ) | ||
|
|
||
| def setUp(self): | ||
| metadata_file = open("metadata.yaml") |
There was a problem hiding this comment.
this is dependent on the invocation directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: this PR was split out of #340.)
Issue
The self-scrape job is "down" when prometheus is related to traefik.The external hostname is not passed to prom_scrape constructor for the self-scraping endpoint.
Solution
Use external_url in constructing the self-scraping job.
Note: the quality of the solution in this PR is affected by canonical/traefik-k8s-operator#78.
Testing Instructions
Deploy prom and relate to traefik. Then look at prom's
/api/v1/targets.Release Notes
Fix ingress usage.