Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Disable linting for docs #437

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

dragomirp
Copy link
Contributor

Disable codespell for docs, since typos there will break the build and we should update those in discourse rather than fix in repo

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.79%. Comparing base (6a4a868) to head (b6ceffb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   71.79%   71.79%           
=======================================
  Files           8        8           
  Lines        1280     1280           
  Branches      243      243           
=======================================
  Hits          919      919           
  Misses        276      276           
  Partials       85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragomirp dragomirp marked this pull request as ready for review October 8, 2024 11:46
@dragomirp dragomirp requested review from a team, taurus-forever, marceloneppel, lucasgameiroborges and a-velasco and removed request for a team October 8, 2024 11:46
Copy link
Contributor

@a-velasco a-velasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with disabling linting here. With the current docs setup it does not make sense for this to affect the build. It can be done separately with Vale and in the sync-docs branch only.

@dragomirp dragomirp merged commit 614049a into main Oct 8, 2024
53 checks passed
@dragomirp dragomirp deleted the disable-linting-for-docs branch October 8, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants