[DPE-1766] Juju 3 peer secrets #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
force-pushed
the
dpe-1766-peer-secrets
branch
from
4aad3b1
to
425b22e
Compare
dragomirp
force-pushed
the
dpe-1766-peer-secrets
branch
from
385f642
to
c882f60
Compare
dragomirp
commented
Aug 10, 2023
Comment on lines
+423
to
+427
| def _normalize_secret_key(self, key: str) -> str: | ||
| new_key = key.replace("_", "-") | ||
| new_key = new_key.strip("-") | ||
|
|
||
| return new_key |
There was a problem hiding this comment.
PGB is storing relation based secrets with generated names, so we cannot simply use an override mapping.
dragomirp
commented
Sep 4, 2023
Comment on lines
-127
to
-131
| - name: Dump logs | ||
| uses: canonical/charm-logdump-action@main | ||
| if: failure() | ||
| with: | ||
| app: pgbouncer-k8s |
There was a problem hiding this comment.
Doesn't seem to be doing anything useful.
dragomirp
commented
Sep 4, 2023
Comment on lines
+240
to
+242
| if not (password := self.charm.get_secret(APP_SCOPE, user)): | ||
| password = pgb.generate_password() | ||
| self.charm.peers.add_user(user, password) |
There was a problem hiding this comment.
If password is already generated and set, don't regenerate it. This was causing the consistent mattermost failures.
marceloneppel
approved these changes
Sep 5, 2023
taurus-forever
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Charm doesn't use secrets for internal sensitive values
Solution