Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add release info to homepage #533

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

dwilding
Copy link
Contributor

@dwilding dwilding commented Dec 9, 2024

This PR adds a new section called "Releases" to the docs homepage. The purpose is to help newcomers find the Pebble release notes.

Preview build: https://canonical-pebble--533.com.readthedocs.build/en/533/

(While making this change, I also removed a couple of trailing periods in the "Project and community" bullets, for consistency)


Pebble releases are tracked in GitHub.

[Read the release notes](https://github.com/canonical/pebble/releases)
Copy link
Contributor

@IronCore864 IronCore864 Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing period at the end?

I can understand the removal of the other two periods below because it is a list of phrases, not a list of sentences. But here it's a standalone sentence in its own paragraph, so I think no matter how long it is (even a single word), it should end with a period?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'd probably join this sentence with the previous paragraph -- seems to go with that, and a separate paragraph seems unnecessary.

Copy link
Contributor

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!


Pebble releases are tracked in GitHub.

[Read the release notes](https://github.com/canonical/pebble/releases)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'd probably join this sentence with the previous paragraph -- seems to go with that, and a separate paragraph seems unnecessary.

@benhoyt benhoyt changed the title (docs) add release info to homepage docs: add release info to homepage Dec 9, 2024
@benhoyt
Copy link
Contributor

benhoyt commented Dec 9, 2024

@dwilding Note the tweak to the PR title for conventional commit style.

@dwilding
Copy link
Contributor Author

@IronCore864, @benhoyt I really want "Read the release notes" to stand alone if possible - I want to treat this link more like a button and have it completely unmissable, not part of text that we expect people to read. (That's also why I would drop the period, because it's a fragment that's not functioning as a sentence)

Trying an alternative layout:

Read the release notes

Pebble releases are tracked in GitHub. To get notified when there's a new release, watch the Pebble repository.

If you don't like this, I'll fold 😄

@benhoyt
Copy link
Contributor

benhoyt commented Dec 10, 2024

Let's do it!

@dwilding dwilding merged commit 3c8d2b6 into canonical:master Dec 10, 2024
18 checks passed
@dwilding dwilding deleted the homepage-release-info branch December 10, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants