Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: create reusable content for how to install guide and the tutorial #433

Merged
merged 8 commits into from
Jun 24, 2024
Merged

docs: create reusable content for how to install guide and the tutorial #433

merged 8 commits into from
Jun 24, 2024

Conversation

IronCore864
Copy link
Contributor

@IronCore864 IronCore864 commented Jun 17, 2024 •
edited
Loading

Create some reusable content for the tutorial, how-to-install doc, pebble install verification, and references.

Changes:

  • make installing and verifying pebble content reusable
  • refactor the how-to-install doc to use reusable content
  • refactor the tutorial to use reusable content
  • mark the pebble help reference doc with the reference link
  • toc of the reference page now is visible

@IronCore864 IronCore864 marked this pull request as ready for review June 20, 2024 05:33
@IronCore864 IronCore864 requested a review from benhoyt June 20, 2024 05:33
benhoyt
benhoyt requested changes Jun 20, 2024
View reviewed changes
docs/reuse/common-blocks.md Outdated Show resolved Hide resolved
docs/reuse/common-blocks.md Outdated Show resolved Hide resolved
docs/reuse/common-blocks.md Outdated Show resolved Hide resolved
docs/tutorial/getting-started.md Outdated Show resolved Hide resolved
docs/how-to/install-pebble.md Outdated Show resolved Hide resolved
docs/reuse/common-blocks.md Outdated Show resolved Hide resolved
docs/reference/pebble-help.md Show resolved Hide resolved
docs/reuse/common-blocks.md Outdated Show resolved Hide resolved
@IronCore864 IronCore864 requested a review from benhoyt June 21, 2024 05:30
benhoyt
benhoyt approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks. Let's ensure we have Anne's review too.

@IronCore864
Copy link
Contributor Author

In a sync with Anne, there is no more comment from her side. Merging now.

@IronCore864 IronCore864 merged commit d822e9f into canonical:master Jun 24, 2024
16 checks passed
@IronCore864 IronCore864 deleted the reusable-content-and-how-to-install branch June 24, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhoyt benhoyt benhoyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IronCore864 @benhoyt