Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that "pebble logs -f" only follows currently-running services #110

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

benhoyt
Copy link
Contributor

@benhoyt benhoyt commented Mar 10, 2022

It would be quite a significant refactoring to have "pebble logs -f"
subscribe to new services being started and wire that through, so for
now at least, just document the current behaviour.

See #56

It would be quite an significant refactoring to have "pebble logs -f"
subscribe to new services being started and wire that through, so for
now at least, just document the current behaviour. It seems unlikely to
affect people in practice, as the service(s) you're debugging will
likely be running.
Copy link
Member

@hpidcock hpidcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously doesn't fix the problem but alerts users to the edge case.

@benhoyt benhoyt merged commit d0b0e26 into canonical:master Mar 28, 2022
@benhoyt benhoyt deleted the logs-follow-doc-tweak branch March 28, 2022 00:33
jujubot added a commit to juju/juju that referenced this pull request Apr 4, 2022
#13927

This PR updates Juju to use the latest version of Pebble, which making Pebble a child process subreaper and a couple of minor fixes. It includes these three Pebble PRs:

* canonical/pebble#101
* canonical/pebble#110
* canonical/pebble#109

I've done a quick test to ensure that the `snappass-test` sidecar charm deploys correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants