-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor rocky8 #201
Refactor rocky8 #201
Conversation
@alexsander-souza , please check out the changes for rocky8. This is similar to what we did with centos7. Do you ever use uncompressed qcow files to verify the build ?
If not, this can be addressed with the following stanza: post-processors {
post-processor "shell-local" {
inline = [
"SOURCE=rocky8",
"OUTPUT=${var.filename}",
"source ../scripts/fuse-nbd",
"source ../scripts/fuse-tar-root"
]
inline_shebang = "/bin/bash -e"
}
post-processor "artifice" {
files = ["rocky8.tar.gz"]
}
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
No, we don't need the qcow image after create the tarball. You can update this PR with this change if you want. |
03af5f4
to
13c974a
Compare
13c974a
to
f27ece2
Compare
@alexsander-souza, all looks good now. No reliance on make. We can run Changes summary:
|
@alexsander-souza , please merge/comment so I could move forward to the next distro. If possible, please also merge #200 |
Relates to #197
Remove reliance on make when building the Rocky 8 image.