improve ESXi build #139
Merged
improve ESXi build #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brigaccess
approved these changes
Sep 14, 2023
| * The VMware ESXi installation ISO must be downloaded manually. You can download it [here.](https://www.vmware.com/go/get-free-esxi) | ||
|
|
||
| ## Requirements (to deploy the image) | ||
|
|
||
| * [MAAS](https://maas.io) 2.5 or above, [MAAS](https://maas.io) 2.6 required for storage configuration | ||
| * [MAAS](https://maas.io) 3.0 or above |
There was a problem hiding this comment.
I believe the previous section said 3.3 and above?
| @@ -1,12 +1,13 @@ | |||
| #!/bin/sh | |||
| #!/bin/sh -x | |||
There was a problem hiding this comment.
Same question as with the other review: why do we need this?
make fusefs handling more robust. review documentation Co-authored-by: craig bender <[email protected]>
alexsander-souza
force-pushed
the
esxi_better_support
branch
from
901867c to
6ccee9b
Compare
|
fixes #128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make fusefs handling more robust. review documentation